Skip to content

deps: move tailwind to production in ui-components#8015

Merged
avivkeller merged 1 commit intomainfrom
fix-build
Jul 24, 2025
Merged

deps: move tailwind to production in ui-components#8015
avivkeller merged 1 commit intomainfrom
fix-build

Conversation

@bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Jul 23, 2025 •
edited
Loading

Description

Validation

Related Issues

https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1753312992837869

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Jul 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 23, 2025 11:59pm

@bjohansebas bjohansebas added the github_actions:pull-request Trigger Pull Request Checks label Jul 23, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 80 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟠 89 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@codecov
Copy link

codecov bot commented Jul 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.01%. Comparing base (2d1abe5) to head (ca7cafb).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8015      +/-   ##
==========================================
+ Coverage   72.95%   73.01%   +0.06%     
==========================================
  Files          95       95              
  Lines        8317     8317              
  Branches      215      214       -1     
==========================================
+ Hits         6068     6073       +5     
+ Misses       2248     2243       -5     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjohansebas bjohansebas marked this pull request as ready for review July 24, 2025 00:02
Copilot AI review requested due to automatic review settings July 24, 2025 00:02
@bjohansebas bjohansebas requested review from a team as code owners July 24, 2025 00:02
Copilot AI reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the dependency structure for Tailwind CSS and related PostCSS packages by moving them from devDependencies to dependencies in the ui-components package. The change suggests these packages are now required at runtime rather than just during development/build time.

Key Changes

  • Moved @tailwindcss/postcss, postcss-calc, and tailwindcss from devDependencies to dependencies
  • Updated tailwindcss to use catalog versioning for consistency with other dependencies
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@bjohansebas bjohansebas changed the title deps: tailwind such as dependencie deps: tailwind such as dependency Jul 24, 2025
@bjohansebas bjohansebas added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Jul 24, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 24, 2025
@MattIPv4 MattIPv4 changed the title deps: tailwind such as dependency deps: move tailwind to production in ui-components Jul 24, 2025
@bjohansebas bjohansebas enabled auto-merge July 24, 2025 00:15
@bjohansebas bjohansebas disabled auto-merge July 24, 2025 00:15
@bjohansebas
Copy link
Member Author

bjohansebas commented Jul 24, 2025

fast-tracking, so I can keep working on fixing a build issue I have in my PR

avivkeller
avivkeller approved these changes Jul 24, 2025
View reviewed changes
bjohansebas added a commit that referenced this pull request Jul 24, 2025
@bjohansebas
change from #8015
7373883
@avivkeller avivkeller added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 331ad08 Jul 24, 2025
28 of 29 checks passed
@avivkeller avivkeller deleted the fix-build branch July 24, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller approved these changes

Copilot code review Copilot Copilot left review comments

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees

No one assigned

Labels

fast-track Fast Tracking PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bjohansebas @MattIPv4 @avivkeller